Mask off-detector slits/orders #1897
Open
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbwestfall
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
There is some redundancy with other operations in edgetrace.py (look for places where we flag OFFDETECTOR and the trace_pixels_off_detector function), and I think I'd rather these checks be in check_synced instead of get_slits. I.e., ideally get_slits would just parse the EdgeTraceSet object into the SlitTraceSet one. But ... I think it's fine to leave it as is, particularly because it makes sense with the trim_spec stuff that precedes it.
Three minor requests:
- I would change the text for the explanation of the
mask_off_detectorparameter to something like: "Mask spectral regions in each slit/order where more than 50% of the slit spatial coverage falls off the detector." - Add a comment in the release doc
- Update the docs (ie., run
make htmland add any changed files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to mask the portion of a slit/order that is more than 50% outside the detector. This is done, simply, by changing the values of
specminandspecmaxduring slit tracing. This approach allows to avoid funny behaviors during the object extraction where the portion of the slit/order that is on the detector becomes smaller and smaller.This masking is not done by default but a new parameter
mask_off_detectorhas been introduced and it is set to True by default only for keck_hires.Tests already run and pass. One unit test failure is my machine usual problem with setup_gui.
FAILED ../../../Pypeit/PypeIt-development-suite/unit_tests/test_setup_gui.py::test_pypeit_obslog_model - PermissionError: [Errno 1] Operation not permitted: '/private/var/folders/x...